New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change node url for proposal #5956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have one requested change with some feedback:
- When I change the node URL, it isn't reactive in the
ProposalInformationPane
packages/shared/components/atoms/buttons/ProposalDetailsButton.svelte
Outdated
Show resolved
Hide resolved
I didn't notice this the last time I tested this PR, but we should adjust the locales when editing a proposal to something like "Successfully edited proposal" instead of "Proposal successfully added" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Just have one last thing we should do before merging in 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist