Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change node url for proposal #5956

Merged
merged 12 commits into from Feb 24, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:feature Adding a new feature or functionality context:governance stardust Related to the Stardust Protocol labels Feb 22, 2023
@MarkNerdi996 MarkNerdi996 self-assigned this Feb 22, 2023
@MarkNerdi996 MarkNerdi996 linked an issue Feb 22, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one requested change with some feedback:

  • When I change the node URL, it isn't reactive in the ProposalInformationPane

@maxwellmattryan
Copy link
Contributor

I didn't notice this the last time I tested this PR, but we should adjust the locales when editing a proposal to something like "Successfully edited proposal" instead of "Proposal successfully added"

Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Just have one last thing we should do before merging in 🙏

@nicole-obrien
Copy link
Contributor

Dropdown is hidden on the popup

Screenshot 2023-02-24 at 10 03 17

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit 1c5a03c into develop Feb 24, 2023
@nicole-obrien nicole-obrien deleted the feat/change-node-url-for-proposal branch February 24, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:governance stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
3 participants