Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: improve quantity and other optional inputs on mint nft flow #5963

Merged
merged 5 commits into from Feb 23, 2023

Conversation

nicole-obrien
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien added type:enhancement Enhancement to existing feature stardust Related to the Stardust Protocol context:collectibles labels Feb 23, 2023
@nicole-obrien nicole-obrien self-assigned this Feb 23, 2023
@nicole-obrien nicole-obrien linked an issue Feb 23, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit 3dc2747 into develop Feb 23, 2023
@MarkNerdi996 MarkNerdi996 deleted the fix/quantity-on-mint-nft branch February 23, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:collectibles stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix ux of quantity feature of minting NFTS
2 participants