Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update wallet.rs #5964

Merged
merged 10 commits into from Feb 24, 2023
Merged

chore: update wallet.rs #5964

merged 10 commits into from Feb 24, 2023

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Feb 23, 2023

Summary

Please summarize your changes, describing what they are and why they were made.

⚠️ The update contains breaking changes!

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added the type:chore House-keeping etc. label Feb 23, 2023
@maxwellmattryan maxwellmattryan self-assigned this Feb 23, 2023
@maxwellmattryan maxwellmattryan marked this pull request as ready for review February 23, 2023 17:24
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • profile migration works
  • participation overview works

LGTM 👍

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit 63869b9 into develop Feb 24, 2023
@nicole-obrien nicole-obrien deleted the chore/update-wallet.rs branch February 24, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update wallet.rs [Task]: Debug get_participation_overview occassionally returning an empty array
3 participants