Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: OnboardingLayout #5979

Merged
merged 6 commits into from Feb 28, 2023
Merged

refactor: OnboardingLayout #5979

merged 6 commits into from Feb 28, 2023

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Feb 25, 2023 •
edited

Summary

Adapts OnboardingLayout to code conventions, moves it to desktop/components and removes mobile code from it

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:chore House-keeping etc. type:refactor Refactor code package:desktop platform:desktop Desktop application type:ui stardust Related to the Stardust Protocol labels Feb 25, 2023
@jeeanribeiro jeeanribeiro self-assigned this Feb 25, 2023
@jeeanribeiro jeeanribeiro linked an issue Feb 25, 2023 that may be closed by this pull request
[Task]: Remove all “if $mobile” code from OnboardingLayout.svelte and move it to desktop #5978
Closed
@jeeanribeiro jeeanribeiro changed the title refactor: onboarding layout refactor: OnboardingLayout Feb 25, 2023
begonaalvarezd
begonaalvarezd requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great, just adding some minor comments 🙏🏼

packages/desktop/components/OnboardingLayout.svelte Outdated Show resolved Hide resolved
packages/desktop/components/OnboardingLayout.svelte Outdated Show resolved Hide resolved
packages/desktop/components/OnboardingLayout.svelte Outdated Show resolved Hide resolved
@begonaalvarezd begonaalvarezd merged commit da8b94c into develop Feb 28, 2023
@begonaalvarezd begonaalvarezd deleted the refactor/onboarding-layout branch February 28, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@paul-boegelsack paul-boegelsack Awaiting requested review from paul-boegelsack

@maxwellmattryan maxwellmattryan Awaiting requested review from maxwellmattryan

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
platform:desktop Desktop application stardust Related to the Stardust Protocol type:chore House-keeping etc. type:refactor Refactor code type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Remove all “if $mobile” code from OnboardingLayout.svelte and move it to desktop
2 participants
@jeeanribeiro @begonaalvarezd