Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no empty string into node object #6002

Merged
merged 6 commits into from Mar 1, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Mar 1, 2023

Summary

Fixes sending empty strings as properties for the node object. This results in 400 errors.
...

Changelog

- Build node object within NodeConfigurationForm
- Use enums instead of strings for TextType

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi requested a review from cvarley100 as a code owner March 1, 2023 12:36
@Tuditi Tuditi self-assigned this Mar 1, 2023
@Tuditi Tuditi linked an issue Mar 1, 2023 that may be closed by this pull request
3 tasks
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good!
just a few coding convention reminders

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tuditi Tuditi requested a review from MarkNerdi996 March 1, 2023 14:41
@nicole-obrien nicole-obrien merged commit d39d4ea into develop Mar 1, 2023
@nicole-obrien nicole-obrien deleted the fix/no-empty-string-into-node-object branch March 1, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix: do not use empty strings into node object
3 participants