Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: RecoveryPhrase & ViewMnemonicView & VerifyMnemonicView #6004

Merged
merged 13 commits into from Mar 3, 2023
Merged

refactor: RecoveryPhrase & ViewMnemonicView & VerifyMnemonicView #6004

merged 13 commits into from Mar 3, 2023

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Mar 2, 2023 •
edited

Changelog

- Makes RecoveryPhrase platform-agnostic
- Refactors desktop & mobile ViewMnemonicView
- Refactors desktop & mobile VerifyMnemonicView
- Moves VerifyMnemonicView platforms shared logic to utils

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:chore House-keeping etc. type:refactor Refactor code package:desktop platform:desktop Desktop application type:ui stardust Related to the Stardust Protocol labels Mar 2, 2023
@jeeanribeiro jeeanribeiro self-assigned this Mar 2, 2023
@jeeanribeiro jeeanribeiro linked an issue Mar 2, 2023 that may be closed by this pull request
[Task]: Refactor RecoveryPhrase.svelte to be used on both platforms #6000
Closed
paul-boegelsack
paul-boegelsack approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring, especially the RecoveryPhrase 🔥 👍 I only have a few little things

packages/desktop/views/onboarding/views/profile-backup/views/VerifyMnemonicView.svelte Outdated Show resolved Hide resolved
packages/desktop/views/onboarding/views/profile-backup/views/VerifyMnemonicView.svelte Outdated Show resolved Hide resolved
packages/desktop/views/onboarding/views/profile-backup/views/ViewMnemonicView.svelte Outdated Show resolved Hide resolved
packages/desktop/views/onboarding/views/profile-backup/views/VerifyMnemonicView.svelte Outdated Show resolved Hide resolved
packages/mobile/views/onboarding/views/profile-backup/views/VerifyMnemonicView.svelte Outdated Show resolved Hide resolved
packages/mobile/views/onboarding/views/profile-backup/views/VerifyMnemonicView.svelte Outdated Show resolved Hide resolved
packages/mobile/views/onboarding/views/profile-backup/views/VerifyMnemonicView.svelte Outdated Show resolved Hide resolved
packages/mobile/views/onboarding/views/profile-backup/views/ViewMnemonicView.svelte Outdated Show resolved Hide resolved
packages/mobile/views/onboarding/views/profile-backup/views/ViewMnemonicView.svelte Outdated Show resolved Hide resolved
packages/shared/components/RecoveryPhrase.svelte Outdated Show resolved Hide resolved
@paul-boegelsack paul-boegelsack self-requested a review March 3, 2023 08:57
paul-boegelsack
paul-boegelsack suggested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@jeeanribeiro
Copy link
Contributor Author

Nice refactoring, especially the RecoveryPhrase 🔥 👍 I only have a few little things

Thanks a lot for the review, nice catch for all the details 👏 👏

@paul-boegelsack paul-boegelsack merged commit 045e368 into develop Mar 3, 2023
@paul-boegelsack paul-boegelsack deleted the refactor/recovery-phrase branch March 3, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-boegelsack paul-boegelsack paul-boegelsack approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

@maxwellmattryan maxwellmattryan Awaiting requested review from maxwellmattryan

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
platform:desktop Desktop application stardust Related to the Stardust Protocol type:chore House-keeping etc. type:refactor Refactor code type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor RecoveryPhrase.svelte to be used on both platforms
2 participants
@jeeanribeiro @paul-boegelsack