Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revote flow with ledger #6019

Merged
merged 17 commits into from Mar 6, 2023
Merged

Fix: revote flow with ledger #6019

merged 17 commits into from Mar 6, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Mar 2, 2023

Summary

Improve the voting flow, so that we can revote seamlessly with ledger. Additionally, we refactored the flow.

...

Changelog

- Replaced `hasPendingGovernanceTransaction[accountIndex]` with `hasVotingPowerTransactionInProgress` & `hasVotingTransactionInProgress` properties
- Revote popup can be closed now
- Meatball menu with revote option added
- Added shouldRevote to persisted account metadata

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi self-assigned this Mar 2, 2023
@Tuditi Tuditi force-pushed the fix/revote-flow-with-ledger branch from 5528a2b to b3593d8 Compare March 2, 2023 17:06
@Tuditi Tuditi changed the title Fix/revote flow with ledger Fix: revote flow with ledger Mar 2, 2023
@Tuditi Tuditi marked this pull request as ready for review March 2, 2023 20:41
@Tuditi Tuditi linked an issue Mar 3, 2023 that may be closed by this pull request
7 tasks
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tuditi Tuditi merged commit b467ec6 into develop Mar 6, 2023
4 checks passed
@Tuditi Tuditi deleted the fix/revote-flow-with-ledger branch March 6, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Improve revote flow
2 participants