Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When deleting account and transferring funds switch to internal #607

Merged
merged 1 commit into from Mar 22, 2021

Conversation

obany
Copy link
Contributor

@obany obany commented Mar 22, 2021

Description of change

If you are deleting an account that has funds the button says "Internal Transfer" but it doesn't actually switch to internal transfer. This fix adds an isInternal flag to send params which will initialise the UI to the correct location.

Fixes #545

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Tested on windows

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner March 22, 2021 10:51
@laumair laumair self-requested a review March 22, 2021 13:53
@laumair laumair merged commit 7808adc into develop Mar 22, 2021
@laumair laumair deleted the fix/delete-account-transfer branch March 22, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically open "Move funds" tab when deleting account with balance
2 participants