Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stronghold badge #6084

Merged
merged 15 commits into from Mar 7, 2023
Merged

feat: add stronghold badge #6084

merged 15 commits into from Mar 7, 2023

Conversation

jeeanribeiro
Copy link
Contributor

Summary

closes #6007

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:feature Adding a new feature or functionality package:shared stardust Related to the Stardust Protocol labels Mar 6, 2023
@jeeanribeiro jeeanribeiro self-assigned this Mar 6, 2023
@jeeanribeiro jeeanribeiro mentioned this pull request Mar 6, 2023
Closed
3 tasks
MarkNerdi996
MarkNerdi996 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

After #6090 is in, we can merge this as well 👍

@MarkNerdi996 MarkNerdi996 changed the base branch from develop to feat/add-stronghold-version-to-profile March 7, 2023 13:39
Base automatically changed from feat/add-stronghold-version-to-profile to develop March 7, 2023 13:54
@MarkNerdi996 MarkNerdi996 marked this pull request as ready for review March 7, 2023 13:56
@MarkNerdi996 MarkNerdi996 merged commit 8cb0b3a into develop Mar 7, 2023
@MarkNerdi996 MarkNerdi996 deleted the feat/add-badge-stronghold branch March 7, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: 3. Add warning icon to profile badge / icon
2 participants
@jeeanribeiro @MarkNerdi996