Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds update stronghold view #6087

Merged
merged 10 commits into from Mar 8, 2023
Merged

feat: adds update stronghold view #6087

merged 10 commits into from Mar 8, 2023

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Mar 7, 2023 •
edited

Summary

closes #6048

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:feature Adding a new feature or functionality package:desktop platform:desktop Desktop application type:ui stardust Related to the Stardust Protocol labels Mar 7, 2023
@jeeanribeiro jeeanribeiro self-assigned this Mar 7, 2023
@jeeanribeiro jeeanribeiro linked an issue Mar 7, 2023 that may be closed by this pull request
[Task]: 6. Add update stronghold view and UI to update stronghold router #6048
Closed
3 tasks
This was referenced Mar 7, 2023
Closed
Merged
@MarkNerdi996 MarkNerdi996 force-pushed the feat/add-update-stronghold-view branch from 9a8aea5 to b79be2c Compare March 7, 2023 14:38
@MarkNerdi996 MarkNerdi996 marked this pull request as ready for review March 7, 2023 14:40
Base automatically changed from feat/update-stronghold-router to develop March 7, 2023 15:32
@jeeanribeiro jeeanribeiro force-pushed the feat/add-update-stronghold-view branch from 3619d3d to b10ae8a Compare March 7, 2023 15:51
@jeeanribeiro jeeanribeiro force-pushed the feat/add-update-stronghold-view branch from b10ae8a to 5343326 Compare March 7, 2023 16:04
MarkNerdi996
MarkNerdi996 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit 7db1923 into develop Mar 8, 2023
4 checks passed
@MarkNerdi996 MarkNerdi996 deleted the feat/add-update-stronghold-view branch March 8, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
platform:desktop Desktop application stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: 6. Add update stronghold view and UI to update stronghold router
2 participants
@jeeanribeiro @MarkNerdi996