New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix toasts #6129
Merged
Merged
fix: fix toasts #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkNerdi996
added
type:fix
Fix for bug
stardust
Related to the Stardust Protocol
labels
Mar 13, 2023
4 tasks
MarkNerdi996
force-pushed
the
fix/fix-toasts
branch
from
March 13, 2023 08:47
6c8c1fd
to
860b804
Compare
Tuditi
suggested changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're passing all the properties of the toast
variable to Toast
. Let's clean it up and just pass toast
.
Tuditi
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥
MarkNerdi996
added a commit
that referenced
this pull request
Mar 17, 2023
* fix: add error catch on update check * chore: increment version * feat: update proposal card color (#6118) * chore: hide edges of percentage bar * fix: only show dismiss button by default in mobile app (#6114) Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com> * chore: pass showDismiss reactively * chore: update wallet.rs (#6125) * enhancement: remove placeholder on images (#6124) * enhancement: remove placeholder on nft images * fix: fix background png nfts * chore: increment desktop version to `2.1.0-beta-3` * fix: fix royalty validations (#6127) * fix: fix royalty validations * chore: fix errors & show error without overlap --------- Co-authored-by: Tuditi <daviddetroch@pm.me> * feat: New Crowdin translations by Github Action (#6111) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com> * fix: fix toasts (#6129) * fix: fix toasts * chore: imporve code of toasts * fix: fix toasts again * chore: update wallet.rs (#6131) * chore: update version * chore: update version * chore: update wallet.rs (#6174) * chore: update version * chore: enable mainnet profiles in feature flags * chore: increment desktop version to `2.1.0` * fix: recover from empty client options * fix: update active profile instead of only the persisted profile * fix: use 5 sec milestone interval * fix: remove menu item from electron menu Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com> * fix: test --------- Co-authored-by: Mark Nardi <mark.nardi@iota.org> Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com> Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com> Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com> Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com> Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist