Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix toasts #6129

Merged
merged 3 commits into from Mar 13, 2023
Merged

fix: fix toasts #6129

merged 3 commits into from Mar 13, 2023

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:fix Fix for bug stardust Related to the Stardust Protocol labels Mar 13, 2023
@MarkNerdi996 MarkNerdi996 self-assigned this Mar 13, 2023
@MarkNerdi996 MarkNerdi996 linked an issue Mar 13, 2023 that may be closed by this pull request
4 tasks
@MarkNerdi996 MarkNerdi996 changed the base branch from develop to release/desktop-2.1.0 March 13, 2023 08:36
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're passing all the properties of the toast variable to Toast. Let's clean it up and just pass toast.

Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit a11f01d into release/desktop-2.1.0 Mar 13, 2023
@Tuditi Tuditi deleted the fix/fix-toasts branch March 13, 2023 10:28
MarkNerdi996 added a commit that referenced this pull request Mar 17, 2023
* fix: add error catch on update check

* chore: increment version

* feat: update proposal card color (#6118)

* chore: hide edges of percentage bar

* fix: only show dismiss button by default in mobile app (#6114)

Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>

* chore: pass showDismiss reactively

* chore: update wallet.rs (#6125)

* enhancement: remove placeholder on images (#6124)

* enhancement: remove placeholder on nft images

* fix: fix background png nfts

* chore: increment desktop version to `2.1.0-beta-3`

* fix: fix royalty validations (#6127)

* fix: fix royalty validations

* chore: fix errors & show error without overlap

---------

Co-authored-by: Tuditi <daviddetroch@pm.me>

* feat: New Crowdin translations by Github Action (#6111)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>

* fix: fix toasts (#6129)

* fix: fix toasts

* chore: imporve code of toasts

* fix: fix toasts again

* chore: update wallet.rs (#6131)

* chore: update version

* chore: update version

* chore: update wallet.rs (#6174)

* chore: update version

* chore: enable mainnet profiles in feature flags

* chore: increment desktop version to `2.1.0`

* fix: recover from empty client options

* fix: update active profile instead of only the persisted profile

* fix: use 5 sec milestone interval

* fix: remove menu item from electron menu

Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>

* fix: test

---------

Co-authored-by: Mark Nardi <mark.nardi@iota.org>
Co-authored-by: Matthew Maxwell <44885822+maxwellmattryan@users.noreply.github.com>
Co-authored-by: Matthew Maxwell <maxwellmattryan@gmail.com>
Co-authored-by: Jean Ribeiro <iamjeanribeiro@gmail.com>
Co-authored-by: MarkNerdi <105642810+MarkNerdi@users.noreply.github.com>
Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix auto upgrade toasts
2 participants