Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update chart data based on active profile currency #770

Merged
merged 1 commit into from Mar 31, 2021

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Mar 29, 2021

Description of change

Update chart data based on active profile currency.
After a currency change, if the previously selected chart currency is not available anymore on the list, it will fallback to USD.

Links to any relevant issues

Fixes issue #681.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Electron Linux

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany merged commit 16cf591 into develop Mar 31, 2021
@obany obany deleted the fix/graph-currency branch March 31, 2021 11:27
@begonaalvarezd begonaalvarezd mentioned this pull request Mar 31, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants