Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: available balance reactivity in SendFormPopup #7756

Merged

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #7427

...

Changelog

- make availableBalance reactive

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda changed the title fix: available balance reactivity in SendFormPopup fix: available balance reactivity in SendFormPopup Nov 30, 2023
@brancoder brancoder self-requested a review December 5, 2023 12:44
Copy link
Collaborator

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesnt work 🙏🏼
I am receiving native tokens and base tokens and the send form does not change

@begonaalvarezd begonaalvarezd merged commit c3f2c47 into develop Jan 25, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/available-balance-reactivity-in-sendformpopup branch January 25, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix available balance reactivity in SendFormPopup
3 participants