Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: kickoff implicit account creation flow #7815

Merged
merged 8 commits into from
Jan 10, 2024
Merged

feat: kickoff implicit account creation flow #7815

merged 8 commits into from
Jan 10, 2024

Conversation

evavirseda
Copy link
Collaborator

@evavirseda evavirseda commented Dec 22, 2023 •
edited by begonaalvarezd

Summary

Changelog

- Add new account route

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda linked an issue Dec 29, 2023 that may be closed by this pull request
[Task]: Add implicit account creation router #7811
Closed
@evavirseda evavirseda requested a review from cpl121 January 2, 2024 09:29
cpl121
cpl121 requested changes Jan 3, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments 🙏🏼

packages/desktop/views/account/AccountRouter.svelte Outdated Show resolved Hide resolved
packages/shared/lib/core/router/enums/app-route.enum.ts Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from cpl121 January 4, 2024 09:02
cpl121
cpl121 requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NJ!

packages/desktop/App.svelte Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from cpl121 January 4, 2024 18:45
cpl121
cpl121 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NJ

begonaalvarezd
begonaalvarezd requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explained what needs to be updated to @cpl121 please discuss with him what needs to be updated
sorry sorry 💔💔 💔

@begonaalvarezd begonaalvarezd removed a link to an issue Jan 10, 2024
[Task]: Add implicit account creation router #7811
Closed
@begonaalvarezd begonaalvarezd changed the title feat: add implicit account creation router feat: kickoff implicit account creation flow Jan 10, 2024
@begonaalvarezd begonaalvarezd merged commit c7bc757 into develop-iota2.0 Jan 10, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-implicit-account-router branch January 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cpl121 cpl121 Awaiting requested review from cpl121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evavirseda @begonaalvarezd @cpl121