Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add implicit account creation wizard and router #7877

Merged
merged 24 commits into from
Jan 11, 2024
Merged

feat: add implicit account creation wizard and router #7877

merged 24 commits into from
Jan 11, 2024

Conversation

evavirseda
Copy link
Collaborator

@evavirseda evavirseda commented Dec 26, 2023 •
edited

Summary

Closes #7810, closes #7811
...

Changelog

- Add implicit account creation wizard
- Create implicit account creation router
- Add locales

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda linked an issue Dec 29, 2023 that may be closed by this pull request
[Task]: Add implicit account creation view #7810
Closed
@evavirseda evavirseda requested a review from cpl121 January 2, 2024 09:30
cpl121
cpl121 requested changes Jan 3, 2024
View reviewed changes
packages/desktop/views/account/multi-step/index.ts Outdated Show resolved Hide resolved
packages/shared/lib/contexts/account/enums/account-state.enum.ts Outdated Show resolved Hide resolved
packages/shared/locales/en.json Outdated Show resolved Hide resolved
packages/shared/locales/en.json Show resolved Hide resolved
packages/desktop/views/account/activate/MainView.svelte Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from cpl121 January 4, 2024 11:58
cpl121
cpl121 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evavirseda evavirseda marked this pull request as draft January 10, 2024 17:11
@evavirseda evavirseda changed the title feat: add implicit account creation view [WIP] feat: add implicit account creation view Jan 10, 2024
Base automatically changed from feat/add-implicit-account-router to develop-iota2.0 January 10, 2024 17:16
@begonaalvarezd begonaalvarezd changed the title [WIP] feat: add implicit account creation view [WIP] feat: add implicit account creation wizard and router Jan 10, 2024
@begonaalvarezd begonaalvarezd linked an issue Jan 10, 2024 that may be closed by this pull request
[Task]: Add implicit account creation router #7811
Closed
@evavirseda evavirseda marked this pull request as ready for review January 11, 2024 11:41
@evavirseda evavirseda requested review from cpl121 and removed request for cpl121 January 11, 2024 11:41
@evavirseda evavirseda changed the title [WIP] feat: add implicit account creation wizard and router feat: add implicit account creation wizard and router Jan 11, 2024
begonaalvarezd
begonaalvarezd requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work 🔥

packages/desktop/lib/routers/actions/initialiseRouters.ts Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/wallet/implicit-account-creation-router.ts Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/wallet/views/WalletView.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/index.js Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/wallet/views/ImplicitAccountCreationView.svelte Show resolved Hide resolved
begonaalvarezd
begonaalvarezd approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@begonaalvarezd begonaalvarezd merged commit f49e87e into develop-iota2.0 Jan 11, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-implicit-account-creation-view branch January 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cpl121 cpl121 Awaiting requested review from cpl121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add implicit account creation router [Task]: Add implicit account creation view
3 participants
@evavirseda @begonaalvarezd @cpl121