Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare UI for implicit account creation STEP 1 #7878

Merged
merged 34 commits into from
Jan 16, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #7812

...

Changelog

- Prepare UI

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda linked an issue Dec 29, 2023 that may be closed by this pull request
@evavirseda evavirseda requested a review from cpl121 January 2, 2024 09:34
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/add-implicit-account-creation-view to develop-iota2.0 January 11, 2024 14:54
packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
@evavirseda evavirseda requested review from begonaalvarezd and cpl121 and removed request for cpl121 January 12, 2024 11:04
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit d9236db into develop-iota2.0 Jan 16, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/prepare-ui-step1 branch January 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Prepare UI for implicit account creation step 1
3 participants