Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prepare UI for implicit account creation STEP 2 #7879

Merged
merged 42 commits into from
Jan 16, 2024
Merged

feat: prepare UI for implicit account creation STEP 2 #7879

merged 42 commits into from
Jan 16, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Clsoes #7813

...

Changelog

- Prepare UI step 2

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda linked an issue Dec 29, 2023 that may be closed by this pull request
[Task]: Prepare UI for implicit account creation step 2 #7813
Closed
@evavirseda evavirseda requested a review from cpl121 January 2, 2024 09:30
cpl121
cpl121 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

evavirseda and others added 18 commits January 4, 2024 10:02
@evavirseda
fix: update naming
0705215
@evavirseda
Merge branch 'feat/add-implicit-account-router' into feat/add-implici…
30a4b81 
…t-account-creation-view
@evavirseda
feat: update naming and improve code
af504e3
@evavirseda
Merge branch 'feat/add-implicit-account-creation-view' into feat/prep…
8bf649d 
…are-ui-step1

packages/desktop/views/account/multi-step/ShowOneTimeAddress.svelte
packages/desktop/views/implicit-account-creation/views/activate/MainView.svelte
@evavirseda
fix: move comment
45b0306
@evavirseda
Merge branch 'feat/prepare-ui-step1' into feat/prepare-ui-step2
8708b6d
@evavirseda
fix import
3390dc2
@evavirseda
Merge branch 'feat/add-implicit-account-router' into feat/add-implici…
ab1919a 
…t-account-creation-view
@evavirseda
fix: remove accountImplicit route and add to wallet tab
bf15770
@evavirseda
fix: improve naming
2d7273d
@evavirseda
Merge branch 'feat/add-implicit-account-router' into feat/add-implici…
45a5ce6 
…t-account-creation-view

packages/desktop/views/implicit-account-creation/ImplicitAccountCreationRouterView.svelte
@evavirseda
Merge branch 'feat/add-implicit-account-creation-view' into feat/prep…
607a1ac 
…are-ui-step1
@evavirseda
Merge branch 'feat/prepare-ui-step1' into feat/prepare-ui-step2
fcd571f
@begonaalvarezd
Update packages/desktop/views/dashboard/wallet/Wallet.svelte
784014c
@begonaalvarezd
Update packages/desktop/views/dashboard/wallet/Wallet.svelte
3f0ab3c
@evavirseda
Merge branch 'feat/add-implicit-account-router' into feat/add-implici…
1347de2 
…t-account-creation-view
@evavirseda
Merge branch 'develop-iota2.0' into feat/add-implicit-account-creatio…
669d0af 
…n-view
@evavirseda
fix: add router
1970e9e
@evavirseda
minor fixes
057c9f5
@evavirseda
Merge branch 'feat/add-implicit-account-creation-view' into feat/prep…
ff906bf 
…are-ui-step1

packages/desktop/views/dashboard/wallet/views/WalletImplicitAccountView.svelte
packages/desktop/views/dashboard/wallet/views/multi-step/MultiStep.svelte
@evavirseda
Merge branch 'feat/prepare-ui-step1' into feat/prepare-ui-step2
0f7062d 
packages/desktop/views/dashboard/wallet/views/multi-step/MultiStep.svelte
@evavirseda
ix: add missing dots
e0e09c8
@evavirseda
Merge branch 'feat/add-implicit-account-creation-view' into feat/prep…
cba69c8 
…are-ui-step1
@evavirseda
fix: colors
84a527c
@evavirseda
Merge branch 'feat/prepare-ui-step1' into feat/prepare-ui-step2
68f5eaf
@evavirseda
fix: remove unnecessary function
1016b96
@evavirseda
fix: rename files
3171553
@evavirseda
fix: move if/else and key block
f4a90f5
@evavirseda
fix: reset after finish
9272310
@evavirseda
Merge branch 'feat/add-implicit-account-creation-view' into feat/prep…
e71e891 
…are-ui-step1
@evavirseda
Merge branch 'develop-iota2.0' into feat/prepare-ui-step1
98e9435 
packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
@evavirseda
Merge branch 'feat/prepare-ui-step1' into feat/prepare-ui-step2
1fb93a3
@evavirseda
fix padding
8a7027a
Base automatically changed from feat/prepare-ui-step1 to develop-iota2.0 January 16, 2024 09:53
@evavirseda
Merge branch 'develop-iota2.0' into feat/prepare-ui-step2
a4c63e4 
packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
@begonaalvarezd begonaalvarezd merged commit 007dedf into develop-iota2.0 Jan 16, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/prepare-ui-step2 branch January 16, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cpl121 cpl121 cpl121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Prepare UI for implicit account creation step 2
3 participants
@evavirseda @begonaalvarezd @cpl121