Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update events to accomodate accounts #7895

Merged
merged 34 commits into from
Jan 19, 2024
Merged

feat: update events to accomodate accounts #7895

merged 34 commits into from
Jan 19, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jan 8, 2024 •
edited

Closes #7840
Closes #7862

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 marked this pull request as ready for review January 9, 2024 08:39
@cpl121 cpl121 changed the title feat: update events to accomodate accounts WIP feat: update events to accomodate accounts Jan 9, 2024
@cpl121 cpl121 linked an issue Jan 9, 2024 that may be closed by this pull request
[Task]: Update events to accomodate accounts #7840
Closed
evavirseda
evavirseda approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
2603f28 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
fix merge
36a0c8d
@cpl121
feat: remove duplicate implicitAccountCreationRouter
f6aedaf
@cpl121
perf: update todo comment for getDepositAddress function
81edbf1
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
55b2d8e 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
feat: update dashboard to route to dashboard or implicit flow based o…
a4aaf36 
…n wallet status
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
7f31e15 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121 cpl121 requested a review from marc2332 January 16, 2024 10:01
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
ed67128 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
95b7648 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
feat: update subscribeToWalletApiEventsForActiveProfile with new Wall…
7469703 
…etEvent
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
270303c 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'feat/…
129b81f 
…update-wallet-state-to-accomodate-accounts' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
fix: move onDestroy to the last view of implicit account creation
4ca6d8b
@cpl121
Merge branches 'feat/update-wallet-state-to-accomodate-accounts' and …
ea7bba0 
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-wallet-state-to-accomodate-accounts
@cpl121
Merge branch 'feat/update-wallet-state-to-accomodate-accounts' of git…
8cce33b 
…hub.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121 cpl121 requested a review from marc2332 January 16, 2024 16:38
Base automatically changed from feat/update-wallet-state-to-accomodate-accounts to develop-iota2.0 January 16, 2024 17:12
@cpl121
Merge branches 'feat/update-events-to-accomodate-accounts' and 'devel…
385d62c 
…op-iota2.0' of github.com:iotaledger/firefly into feat/update-events-to-accomodate-accounts
@cpl121
feat: imporve isImplicitAccountOutput logic
3c4aa02
marc2332
marc2332 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@cpl121 cpl121 linked an issue Jan 17, 2024 that may be closed by this pull request
[Task]: Update wallet events to accomodate updates #7862
Closed
@begonaalvarezd begonaalvarezd merged commit d0f688a into develop-iota2.0 Jan 19, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/update-events-to-accomodate-accounts branch January 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Update wallet events to accomodate updates [Task]: Update events to accomodate accounts
4 participants
@cpl121 @begonaalvarezd @marc2332 @evavirseda