Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hook implicit account logic step3 #7906

Merged
merged 92 commits into from
Jan 23, 2024
Merged

feat: hook implicit account logic step3 #7906

merged 92 commits into from
Jan 23, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jan 17, 2024

Closes #7843

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

marc2332 and others added 30 commits December 21, 2023 17:17
@marc2332
refactor(2.0): Dynamic password
0e58e1a
@marc2332
refactor(2.0): Remove Profile Manager (wip)
2b25b9b
@marc2332
clean up and fix
027b69d
@marc2332
clean up
4bf970b
@marc2332
Merge branch 'refactor/dynamic-password' into refactor/remove-profile…
d5f50d5 
…-manager
@marc2332
clean up more code
a5a8969
@evavirseda
feat: add account to routes
e7fb493
@evavirseda
feat: add to analytics featureflag
f59e885
@evavirseda
feat: add account view and multistep
d8318ab
@evavirseda
style: refinements
ba6be6b
@evavirseda
feat: rename files and add locale
9de9319
@evavirseda
feat: prepare UI step 1
8cea0a2
@evavirseda
feat: add locales
4a19372
@evavirseda
fix: update naming
0705215
@evavirseda
Merge branch 'feat/add-implicit-account-router' into feat/add-implici…
30a4b81 
…t-account-creation-view
@evavirseda
feat: update naming and improve code
af504e3
@evavirseda
Merge branch 'feat/add-implicit-account-creation-view' into feat/prep…
8bf649d 
…are-ui-step1

packages/desktop/views/account/multi-step/ShowOneTimeAddress.svelte
packages/desktop/views/implicit-account-creation/views/activate/MainView.svelte
@evavirseda
fix: move comment
45b0306
@evavirseda
fix import
3390dc2
@evavirseda
Merge branch 'feat/add-implicit-account-router' into feat/add-implici…
ab1919a 
…t-account-creation-view
@evavirseda
feat: hook logic
b796a74
@marc2332
clean up
628f376
@marc2332
adapt and remove for profile-manager related code
60c6836
@marc2332
clean up more code
cc59db7
@marc2332
fmt
3080203
@evavirseda
fix: remove accountImplicit route and add to wallet tab
bf15770
@evavirseda
fix: improve naming
2d7273d
@evavirseda
Merge branch 'feat/add-implicit-account-router' into feat/add-implici…
45a5ce6 
…t-account-creation-view

packages/desktop/views/implicit-account-creation/ImplicitAccountCreationRouterView.svelte
@evavirseda
Merge branch 'feat/add-implicit-account-creation-view' into feat/prep…
607a1ac 
…are-ui-step1
@evavirseda
Merge branch 'feat/prepare-ui-step1' into feat/hook-implicit-account-…
850562f 
…logic-step1
marc2332 and others added 8 commits January 19, 2024 09:07
@marc2332
Merge branch 'develop-iota2.0' into refactor/remove-profile-manager
9496a3a
@marc2332
clean up
03dfb32
@marc2332
clean up
6b161d7
@evavirseda
Merge branch 'develop-iota2.0' into feat/hook-implicit-account-logic-…
a1ada46 
…step2

packages/desktop/views/dashboard/wallet/views/implicit-account-creation-multistep/OneTimeDepositView.svelte
@cpl121
Merge branches 'feat/hook-implicit-account-logic-step3' and 'feat/hoo…
1a073af 
…k-implicit-account-logic-step2' of github.com:iotaledger/firefly into feat/hook-implicit-account-logic-step3
@evavirseda
feat: update logic to go next route
c73fbd2
@evavirseda
fix: update logic
eab3c7f
@cpl121
Merge branches 'feat/hook-implicit-account-logic-step3' and 'feat/hoo…
bd47325 
…k-implicit-account-logic-step2' of github.com:iotaledger/firefly into feat/hook-implicit-account-logic-step3
Base automatically changed from feat/hook-implicit-account-logic-step2 to develop-iota2.0 January 22, 2024 11:52
@cpl121 cpl121 changed the base branch from develop-iota2.0 to refactor/remove-profile-manager January 23, 2024 09:45
@cpl121 cpl121 marked this pull request as ready for review January 23, 2024 10:26
evavirseda
evavirseda approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!! 🚀

Base automatically changed from refactor/remove-profile-manager to develop-iota2.0 January 23, 2024 16:27
@begonaalvarezd begonaalvarezd merged commit 27bfbe5 into develop-iota2.0 Jan 23, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/hook-implicit-account-logic-step3 branch January 23, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Hook logic in implicit account creation step 3
4 participants
@cpl121 @begonaalvarezd @evavirseda @marc2332