feat: set & persist explicit account created from the implicit flow as the selected one #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-account-creation-view
…are-ui-step1 packages/desktop/views/account/multi-step/ShowOneTimeAddress.svelte packages/desktop/views/implicit-account-creation/views/activate/MainView.svelte
…t-account-creation-view
…t-account-creation-view packages/desktop/views/implicit-account-creation/ImplicitAccountCreationRouterView.svelte
cpl121
requested changes
Jan 30, 2024
There was a problem hiding this comment.
amazing job! 🥇
2 more comments
- I think it would be a good idea in
ImplicitAccountCreationViewto checkif ($selectedWallet?.hasImplicitAccountCreationTransactionInProgress && $selectedWallet?.isTransferring)to redirect to step 3. This way, when we receive more extra funds from the faucet, it is not sent to step 2 again - The wallet deposit address does not update properly when the account output is received, and looks empty
cpl121
requested changes
Jan 30, 2024
packages/shared/lib/core/profile/actions/active-profile/login.ts
Outdated
Show resolved
Hide resolved
begonaalvarezd
requested changes
Feb 1, 2024
packages/shared/lib/core/profile/actions/active-profile/login.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/core/profile/actions/active-profile/login.ts
Outdated
Show resolved
Hide resolved
cpl121
requested changes
Feb 5, 2024
packages/shared/lib/core/wallet/actions/events-handlers/handleNewOutputEvent.ts
Outdated
Show resolved
Hide resolved
begonaalvarezd
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist