Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update output models to new TIPs: Basic Output & Foundry Output & NFT Output #7924

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

evavirseda
Copy link
Collaborator

@evavirseda evavirseda commented Jan 24, 2024

Summary

Closes #7857 and closes #7859 and closes #7860

...

Changelog

- Native token is now a feature
- Only one native token per output
- Only Basic and Foundry can hold a NativeTokenFeature

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda changed the base branch from develop to develop-iota2.0 January 24, 2024 10:29
@evavirseda evavirseda changed the title feat: update output models to new TIPs: Basic Output feat: update output models to new TIPs: Basic Output & Foundry Output Jan 24, 2024
@evavirseda evavirseda changed the title feat: update output models to new TIPs: Basic Output & Foundry Output feat: update output models to new TIPs: Basic Output && Foundry Output Jan 24, 2024
@evavirseda evavirseda changed the title feat: update output models to new TIPs: Basic Output && Foundry Output feat: update output models to new TIPs: Basic Output & Foundry Output Jan 24, 2024
@cpl121 cpl121 changed the title feat: update output models to new TIPs: Basic Output & Foundry Output feat: update output models to new TIPs: Basic Output & Foundry Output & NFT Output Jan 31, 2024
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the nft output, I think we could also add the mana to its interface -> packages/shared/lib/core/nfts/interfaces/nft.interface.ts. Also, we would have to update the buildNftFromNftOutput file to get the mana from the output

Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit cf81ce8 into develop-iota2.0 Feb 2, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/update-basicOutput-model branch February 2, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants