Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update milestone logic to slot #7925

Merged
merged 8 commits into from
Feb 1, 2024
Merged

feat: update milestone logic to slot #7925

merged 8 commits into from
Feb 1, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jan 24, 2024 •
edited

Closes #7854
Closes #7891
Closes #7892

Reference

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

This was linked to issues Jan 24, 2024
[Task]: Update milestone logic to slot #7854
Closed
[Task]: Update Timelock Unlock Condition from unix to slot #7891
Closed
[Task]: Update Expiration Unlock Condition from unix to slot #7892
Closed
@cpl121 cpl121 changed the title feat: update milestone logic to slot WIP feat: update milestone logic to slot Jan 25, 2024
@cpl121 cpl121 marked this pull request as ready for review January 25, 2024 16:06
@cpl121
Merge branches 'feat/update-milestone-logic-to-slot' and 'develop-iot…
32fde1f 
…a2.0' of github.com:iotaledger/firefly into feat/update-milestone-logic-to-slot
@cpl121
feat: remove temporary interface
518bcb7
evavirseda
evavirseda approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, just a few suggestions 🙏

packages/shared/lib/core/wallet/utils/transactions/getSenderAddressFromInputs.ts Outdated Show resolved Hide resolved
packages/shared/lib/contexts/governance/utils/isVotingForProposal.ts Outdated Show resolved Hide resolved
packages/shared/lib/contexts/governance/utils/createProposalFromEvent.ts Show resolved Hide resolved
packages/desktop/views/dashboard/governance/views/ProposalDetailsView.svelte Show resolved Hide resolved
@begonaalvarezd begonaalvarezd merged commit 55f0e22 into develop-iota2.0 Feb 1, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/update-milestone-logic-to-slot branch February 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cpl121 @evavirseda @begonaalvarezd