feat: update output models to new TIPs: Alias/Accout Output #7926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evavirseda
force-pushed
the
feat/update-aliasOutput-to-accountOutput
branch
from
77eed69
to
4b06971
Compare
cpl121
requested changes
Jan 31, 2024
packages/desktop/views/dashboard/collectibles/views/CollectiblesDetailsView.svelte
Outdated
Show resolved
Hide resolved
packages/shared/components/activity-info/AccountActivityInformation.svelte
Outdated
Show resolved
Hide resolved
packages/shared/components/activity-info/NftActivityInformation.svelte
Outdated
Show resolved
Hide resolved
packages/shared/lib/core/wallet/types/activities/account-activity.type.ts
Show resolved
Hide resolved
packages/shared/lib/core/wallet/utils/buildFoundryOutputData.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/core/wallet/utils/buildFoundryOutputData.ts
Outdated
Show resolved
Hide resolved
packages/shared/lib/core/wallet/utils/outputs/getSerialNumberFromAccountOutput.ts
Outdated
Show resolved
Hide resolved
…tOutput packages/shared/lib/core/wallet/utils/generateActivity/generateActivities.ts packages/shared/lib/core/wallet/utils/generateActivity/helper/getGovernorAddressFromAnchorOutput.ts packages/shared/lib/core/wallet/utils/generateActivity/helper/getStateControllerAddressFromAnchorOutput.ts packages/shared/lib/core/wallet/utils/generateActivity/helper/index.ts
cpl121
requested changes
Feb 8, 2024
packages/shared/components/activity-info/AccountActivityInformation.svelte
Show resolved
Hide resolved
packages/shared/lib/core/wallet/utils/generateActivity/generateSingleAccountActivity.ts
Show resolved
Hide resolved
packages/shared/lib/core/wallet/utils/generateActivity/generateSingleAccountActivity.ts
Outdated
Show resolved
Hide resolved
packages/shared/components/activity-info/AccountActivityInformation.svelte
Show resolved
Hide resolved
cpl121
requested changes
Feb 8, 2024
cpl121
requested changes
Feb 9, 2024
| for (const accountOutput of accountOutputs) { | ||
| const output = accountOutput.output as AccountOutput | ||
| const activity = await generateSingleAccountActivity(wallet, { | ||
| action: output.accountId === EMPTY_HEX_ID ? ActivityAction.Mint : ActivityAction.Send, |
There was a problem hiding this comment.
Where the condition should be updated is here.
imo, for now, I would put this
action: output.accountId === EMPTY_HEX_ID ? ActivityAction.Send : ActivityAction.Mint,
I would add a comment and update the issue to check this logic
cpl121
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist