Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor stronghold unlock #7971

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Feb 1, 2024

Closes #7934

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 marked this pull request as ready for review February 1, 2024 18:44
@cpl121 cpl121 linked an issue Feb 1, 2024 that may be closed by this pull request
@cpl121 cpl121 changed the title Feat/refactor stronghold unlock feat: refactor stronghold unlock Feb 1, 2024
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!! it makes sense since UnlockStronghold unlocks the stronghold 🚀

@cpl121 cpl121 merged commit 2c2607c into develop-iota2.0 Feb 6, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/refactor-stronghold-unlock branch February 6, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor stronghold unlock and account creation logic
3 participants