Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add acount management list #8002

Merged
merged 19 commits into from
Feb 13, 2024
Merged

feat: add acount management list #8002

merged 19 commits into from
Feb 13, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #7966 and closes #7967

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda marked this pull request as ready for review February 8, 2024 10:22
This was linked to issues Feb 8, 2024
[Task]: Add list of account UI #7966
Closed
[Task]: Add list of account logic #7967
Closed
cpl121
cpl121 requested changes Feb 8, 2024
View reviewed changes
packages/desktop/features/account-management.features.ts Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/account-management/AccountManagement.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/account-management/AccountManagement.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/account-management/AccountManagement.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/account-management/AccountManagement.svelte Show resolved Hide resolved
packages/desktop/views/dashboard/account-management/AccountManagement.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/account-management/AccountManagement.svelte Outdated Show resolved Hide resolved
Base automatically changed from feat/add-account-management-router to develop-iota2.0 February 8, 2024 16:19
@evavirseda
feat: update accountManagement
4fa8d55
@evavirseda
Merge branch 'develop-iota2.0' into feat/add-acount-management-list-ui
3fba6a5 
packages/desktop/views/dashboard/account-management/AccountManagement.svelte
@marc2332 marc2332 self-requested a review February 13, 2024 10:08
cpl121
cpl121 requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal comment 😄

packages/shared/lib/core/wallet/actions/events-handlers/handleNewOutputEvent.ts Outdated Show resolved Hide resolved
cpl121
cpl121 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NJ!! 🥇

@cpl121 cpl121 merged commit 451ffc6 into develop-iota2.0 Feb 13, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/add-acount-management-list-ui branch February 13, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@cpl121 cpl121 cpl121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add list of account logic [Task]: Add list of account UI
3 participants
@evavirseda @marc2332 @cpl121