Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up imports #8008

Merged
merged 15 commits into from
Feb 16, 2024
Merged

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented Feb 7, 2024

Closes #7830

  • Convert imports pointing to shared to the corresponding @whatever path
  • Moved subrouters from packages/desktop to packages/shared so we don't need to use absolute paths when importing routers from packages/desktop in packages/shared`
  • Converted paths with ../../ pointing to a core module to @core/whatever
  • Moved some components from packages/desktop to packages/shared so they can be imported from packages/shared

@marc2332 marc2332 marked this pull request as ready for review February 13, 2024 08:54
@cpl121 cpl121 linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also update the AssetList.svelte?? 🙏

import { Filter } from '@components'

@marc2332
Copy link
Collaborator Author

could also update the AssetList.svelte?? 🙏

import { Filter } from '@components'

The problem here is that Filter is a component from packages/desktop and AssetList is from packages/shared. Currently, there is no way to import in a fancy way things from desktop into shared. Let me see what I can do

@marc2332 marc2332 marked this pull request as draft February 15, 2024 08:14
@marc2332 marc2332 marked this pull request as ready for review February 15, 2024 09:55
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!!

@marc2332 marc2332 marked this pull request as draft February 16, 2024 08:46
@marc2332 marc2332 marked this pull request as ready for review February 16, 2024 08:50
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@begonaalvarezd begonaalvarezd merged commit a053129 into develop-iota2.0 Feb 16, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/clean-up-imports branch February 16, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup imports
3 participants