Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: succesfully issue a block with base token #8024

Merged
merged 8 commits into from
Feb 14, 2024
Merged

feat: succesfully issue a block with base token #8024

merged 8 commits into from
Feb 14, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Feb 9, 2024

Closes #7976

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121
feat: succesfully issue a block with a base token tx WIP
72efa48
@cpl121
Merge branches 'feat/succesfully-issue-a-block-with-base-token' and '…
7c5c342 
…develop-iota2.0' of github.com:iotaledger/firefly into feat/succesfully-issue-a-block-with-base-token
@cpl121
Merge branches 'feat/succesfully-issue-a-block-with-base-token' and '…
43f49f1 
…develop-iota2.0' of github.com:iotaledger/firefly into feat/succesfully-issue-a-block-with-base-token
@cpl121
fix: error to get native token
d068bc4
@cpl121
fix: format
820a3ea
@cpl121 cpl121 marked this pull request as ready for review February 13, 2024 09:22
@cpl121 cpl121 linked an issue Feb 13, 2024 that may be closed by this pull request
[Task]: Succesfully issue a block with a base token tx #7976
Closed
marc2332
marc2332 requested changes Feb 13, 2024
View reviewed changes
packages/shared/lib/core/wallet/utils/send/validateSendConfirmation.ts Outdated
const expirationUnixTime = getUnixTimestampFromNodeInfoAndSlotIndex(
nodeProtocolParameters,
expirationUnlockCondition.slotIndex
expirationUnlockCondition?.slotIndex
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary ? considering you got an if in L12

@cpl121 cpl121 requested a review from marc2332 February 13, 2024 11:03
@cpl121
Merge branches 'feat/succesfully-issue-a-block-with-base-token' and '…
cc3c94f 
…develop-iota2.0' of github.com:iotaledger/firefly into feat/succesfully-issue-a-block-with-base-token
evavirseda
evavirseda approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion, but it looks great 🔥

packages/shared/lib/core/wallet/utils/getDefaultTransactionOptions.ts Show resolved Hide resolved
@marc2332 marc2332 mentioned this pull request Feb 14, 2024
Merged
marc2332
marc2332 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@cpl121 cpl121 merged commit 1056e08 into develop-iota2.0 Feb 14, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/succesfully-issue-a-block-with-base-token branch February 14, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Succesfully issue a block with a base token tx
3 participants
@cpl121 @marc2332 @evavirseda