Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add account info logic #8032

Merged
merged 49 commits into from
Feb 16, 2024
Merged

feat: add account info logic #8032

merged 49 commits into from
Feb 16, 2024

Conversation

evavirseda
Copy link
Collaborator

@evavirseda evavirseda commented Feb 12, 2024 •
edited

Summary

Closes #7969 and closes #7970

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda
feat: add account management router
40512e3
@evavirseda
feat: update icon
b6a15f2
@evavirseda
feat: add account list
b6ceba1
@evavirseda
Merge branch 'develop-iota2.0' into feat/add-account-management-router
094f722
@evavirseda
Merge branch 'develop-iota2.0' into feat/add-acount-management-list-ui
45e6f80
@evavirseda
Merge branch 'develop-iota2.0' into feat/add-account-management-router
97969ac
@evavirseda
Merge branch 'feat/add-account-management-router' into feat/add-acoun…
00136ce 
…t-management-list-ui
@evavirseda
fix: display as isBusy if hasImplicitAccountCreationTransactionInProg…
96d9438 
…ress and disable the password input
@evavirseda
feat: format and truncate address
ebd0372
@evavirseda
feat: cleanup code
b7a6c67
@evavirseda
feat: add features flag
222e941
@evavirseda
feat: add account management details ui
c92a0cb
@evavirseda
feat: add locales
a241985
@evavirseda
feat: enable features
2772f39
@evavirseda
feat: update accountManagement
4fa8d55
@evavirseda
Merge branch 'develop-iota2.0' into feat/add-acount-management-list-ui
3fba6a5 
packages/desktop/views/dashboard/account-management/AccountManagement.svelte
@evavirseda
Merge branch 'feat/add-acount-management-list-ui' into feat/add-accou…
7741032 
…nt-info

packages/desktop/views/dashboard/account-management/AccountManagement.svelte
@evavirseda
feat: use real data
01d151e
@evavirseda evavirseda changed the title feat: use real data feat: add account info logic Feb 12, 2024
Base automatically changed from feat/add-account-info to develop-iota2.0 February 13, 2024 12:18
@evavirseda evavirseda marked this pull request as ready for review February 14, 2024 14:51
This was linked to issues Feb 14, 2024
[Task]: Set main account #7970
Closed
[Task]: Add account info logic #7969
Closed
@cpl121
Merge branches 'feat/add-account-info-logic' and 'develop-iota2.0' of…
d490304 
… github.com:iotaledger/firefly into feat/add-account-info-logic
@cpl121
Merge branches 'feat/add-account-info-logic' and 'develop-iota2.0' of…
0e5e5a9 
… github.com:iotaledger/firefly into feat/add-account-info-logic
@cpl121
fix: format
88cc985
@cpl121
Merge branches 'feat/add-account-info-logic' and 'develop-iota2.0' of…
12ca588 
… github.com:iotaledger/firefly into feat/add-account-info-logic
@cpl121
fix: minor improvements
244f3df
cpl121
cpl121 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NJ

@begonaalvarezd begonaalvarezd merged commit 46e0b3b into develop-iota2.0 Feb 16, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-account-info-logic branch February 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Set main account [Task]: Add account info logic
3 participants
@evavirseda @cpl121 @begonaalvarezd