feat: update logic for details view - display popup activate account button #8060

cpl121 · 2024-02-16T09:29:01Z

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

Desktop
- MacOS
- Linux
- Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or modified tests that prove my changes work as intended
I have verified that new and existing unit tests pass locally with my changes
I have verified that my latest changes pass CI workflows for testing and linting
I have made corresponding changes to the documentation

…t-management-list-ui

…ress and disable the password input

packages/desktop/views/dashboard/account-management/AccountManagement.svelte

…nt-info packages/desktop/views/dashboard/account-management/AccountManagement.svelte

…nt-info

packages/desktop/views/dashboard/account-management/AccountManagement.svelte

…w' and 'feat/add-account-info-logic' of github.com:iotaledger/firefly into feat/update-logic-for-activate-account-in-details-view

…w' and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-logic-for-activate-account-in-details-view

...views/dashboard/wallet/views/implicit-account-creation-multistep/FundConfirmationView.svelte

.../views/dashboard/wallet/views/implicit-account-creation-multistep/AccountCreationView.svelte

packages/desktop/components/AccountManagementList.svelte

evavirseda

looks great, just a few comments 🙏

packages/desktop/components/popups/ActivateAccountPopup.svelte

.../views/dashboard/wallet/views/implicit-account-creation-multistep/AccountCreationView.svelte

...views/dashboard/wallet/views/implicit-account-creation-multistep/FundConfirmationView.svelte

evavirseda

great job 🚀 🧑‍🚀 just conflicts!

…count-in-details-view

marc2332

There seems to be some reactivity problem as my other account only appeared activated after logging out and in again

…w' and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-logic-for-activate-account-in-details-view

marc2332 · 2024-02-20T15:26:30Z

packages/desktop/components/AccountManagementDetails.svelte

    $: hasStakingFeature = hasOutputStakingFeature(selectedOutput)
    $: rawStakedAmount = getStakedAmount(selectedOutput)
    $: formattedStakedAmount = formatTokenAmountBestMatch(rawStakedAmount, getBaseToken())

    function onExplorerClick(): void {
-        const url = `${explorerUrl}/${ExplorerEndpoint.Output}/${selectedOutput.outputId.toString()}`
+        const url = `${explorerUrl}/${ExplorerEndpoint.Output}/${selectedOutput?.outputId?.toString()}`


from a UX point of view, this makes no sense

.../views/dashboard/wallet/views/implicit-account-creation-multistep/AccountCreationView.svelte

evavirseda

let's make sure we take care of this 🙏 accounts won't update until we log out.

Screenshare.-.2024-02-21.10_54_26.AM.mp4

cpl121 · 2024-02-21T12:48:34Z

let's make sure we take care of this 🙏 accounts won't update until we log out.

Screenshare.-.2024-02-21.10_54_26.AM.mp4

That's not related to this issue?

evavirseda · 2024-02-21T12:52:07Z

let's make sure we take care of this 🙏 accounts won't update until we log out.
Screenshare.-.2024-02-21.10_54_26.AM.mp4

That's not related to this issue?

sure! we'll update it in another PR, just a reminder 🙏

marc2332 · 2024-02-22T08:48:12Z

let's make sure we take care of this 🙏 accounts won't update until we log out.
Screenshare.-.2024-02-21.10_54_26.AM.mp4

That's not related to this issue?

~~I don't think so tbh~~

Definitely

…count-in-details-view

evavirseda added 30 commits February 6, 2024 12:14

feat: add account management router

40512e3

feat: update icon

b6a15f2

feat: add account list

b6ceba1

Merge branch 'develop-iota2.0' into feat/add-account-management-router

094f722

Merge branch 'develop-iota2.0' into feat/add-acount-management-list-ui

45e6f80

Merge branch 'develop-iota2.0' into feat/add-account-management-router

97969ac

Merge branch 'feat/add-account-management-router' into feat/add-acoun…

00136ce

…t-management-list-ui

fix: display as isBusy if hasImplicitAccountCreationTransactionInProg…

96d9438

…ress and disable the password input

feat: format and truncate address

ebd0372

feat: cleanup code

b7a6c67

feat: add features flag

222e941

feat: add account management details ui

c92a0cb

feat: add locales

a241985

feat: enable features

2772f39

feat: update accountManagement

4fa8d55

Merge branch 'develop-iota2.0' into feat/add-acount-management-list-ui

3fba6a5

packages/desktop/views/dashboard/account-management/AccountManagement.svelte

Merge branch 'feat/add-acount-management-list-ui' into feat/add-accou…

7741032

…nt-info packages/desktop/views/dashboard/account-management/AccountManagement.svelte

feat: use real data

01d151e

feat: fix wrong merge

b922eec

Merge branch 'develop-iota2.0' into feat/add-acount-management-list-ui

6c40111

feat: add isImplicitAccountAccountOutput function

c01b709

Merge branch 'feat/add-acount-management-list-ui' into feat/add-accou…

2b55cb6

…nt-info packages/desktop/views/dashboard/account-management/AccountManagement.svelte

fix import

d73eb3d

Merge branch 'feat/add-acount-management-list-ui' into feat/add-accou…

2d5e4d9

…nt-info

fix: improve function

1e6710d

Merge branch 'feat/add-acount-management-list-ui' into feat/add-accou…

c74de66

…nt-info

feat: cleanup

826ac45

feat: cleanup

152171e

feat: cleanup

d7f94ed

Merge branch 'feat/add-account-info' into feat/add-account-info-logic

687d022

packages/desktop/views/dashboard/account-management/AccountManagement.svelte

cpl121 added 2 commits February 16, 2024 12:57

fix: minor improvements

244f3df

Merge branches 'feat/update-logic-for-activate-account-in-details-vie…

a66daea

…w' and 'feat/add-account-info-logic' of github.com:iotaledger/firefly into feat/update-logic-for-activate-account-in-details-view

Base automatically changed from feat/add-account-info-logic to develop-iota2.0 February 16, 2024 12:06

Merge branches 'feat/update-logic-for-activate-account-in-details-vie…

487b4ae

…w' and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-logic-for-activate-account-in-details-view

marc2332 reviewed Feb 16, 2024

View reviewed changes

...views/dashboard/wallet/views/implicit-account-creation-multistep/FundConfirmationView.svelte Outdated Show resolved Hide resolved

marc2332 requested changes Feb 16, 2024

View reviewed changes

.../views/dashboard/wallet/views/implicit-account-creation-multistep/AccountCreationView.svelte Outdated Show resolved Hide resolved

marc2332 reviewed Feb 16, 2024

View reviewed changes

packages/desktop/components/AccountManagementList.svelte Outdated Show resolved Hide resolved

fixes

b72e992

cpl121 requested a review from marc2332 February 19, 2024 08:15

evavirseda requested changes Feb 19, 2024

View reviewed changes

feat: update styles

edc0089

evavirseda self-requested a review February 19, 2024 10:00

evavirseda approved these changes Feb 20, 2024

View reviewed changes

Merge branch 'develop-iota2.0' into feat/update-logic-for-activate-ac…

9af8f1e

…count-in-details-view

marc2332 requested changes Feb 20, 2024

View reviewed changes

cpl121 added 2 commits February 20, 2024 12:49

Merge branches 'feat/update-logic-for-activate-account-in-details-vie…

b43ed6f

…w' and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-logic-for-activate-account-in-details-view

fixes

36c1819

cpl121 requested a review from marc2332 February 20, 2024 14:55

marc2332 requested changes Feb 20, 2024

View reviewed changes

marc2332 self-requested a review February 20, 2024 15:45

evavirseda reviewed Feb 21, 2024

View reviewed changes

cpl121 and others added 2 commits February 22, 2024 16:19

Merge branch 'develop-iota2.0' into feat/update-logic-for-activate-ac…

cd4357a

…count-in-details-view

fix: improve UX to open link

5556b27

marc2332 approved these changes Feb 22, 2024

View reviewed changes

fix: improve UX again

f6aecfa

cpl121 merged commit 05bff9c into develop-iota2.0 Feb 22, 2024
3 of 4 checks passed

cpl121 deleted the feat/update-logic-for-activate-account-in-details-view branch February 22, 2024 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update logic for details view - display popup activate account button #8060

feat: update logic for details view - display popup activate account button #8060

cpl121 commented Feb 16, 2024

evavirseda left a comment

evavirseda left a comment •

edited

marc2332 left a comment

marc2332 Feb 20, 2024

evavirseda left a comment

cpl121 commented Feb 21, 2024

evavirseda commented Feb 21, 2024

marc2332 commented Feb 22, 2024 •

edited

feat: update logic for details view - display popup activate account button #8060

feat: update logic for details view - display popup activate account button #8060

Conversation

cpl121 commented Feb 16, 2024

Summary

Changelog

Testing

Platforms

Instructions

Checklist

evavirseda left a comment

Choose a reason for hiding this comment

evavirseda left a comment • edited

Choose a reason for hiding this comment

marc2332 left a comment

Choose a reason for hiding this comment

marc2332 Feb 20, 2024

Choose a reason for hiding this comment

evavirseda left a comment

Choose a reason for hiding this comment

cpl121 commented Feb 21, 2024

evavirseda commented Feb 21, 2024

marc2332 commented Feb 22, 2024 • edited

evavirseda left a comment •

edited

marc2332 commented Feb 22, 2024 •

edited