Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Delegation view UI #8076

Merged
merged 12 commits into from
Feb 26, 2024
Merged

feat: add Delegation view UI #8076

merged 12 commits into from
Feb 26, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Feb 20, 2024

Closes #7987

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

cpl121 and others added 2 commits February 20, 2024 12:08
@cpl121 @evavirseda
feat: add Delegation view UI
5e7d764 
Co-authored-by: evavirseda <evavirseda@users.noreply.github.com>
@cpl121
Merge branches 'feat/add-delegation-view' and 'develop-iota2.0' of gi…
c5b2a2a 
…thub.com:iotaledger/firefly into feat/add-delegation-view
@cpl121 cpl121 marked this pull request as ready for review February 20, 2024 11:13
@cpl121 cpl121 linked an issue Feb 20, 2024 that may be closed by this pull request
[Task]: Add Delegation view UI #7987
Closed
evavirseda
evavirseda requested changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes 🙏 🙈

packages/desktop/views/dashboard/delegation/Delegation.svelte Show resolved Hide resolved
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/delegation/Delegation.svelte Show resolved Hide resolved
packages/shared/components/BoxedIconWithText.svelte Outdated Show resolved Hide resolved
packages/shared/components/BoxedIconWithText.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated Show resolved Hide resolved
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated Show resolved Hide resolved
evavirseda
evavirseda requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more thing!!

packages/desktop/views/dashboard/delegation/Delegation.svelte Show resolved Hide resolved
evavirseda
evavirseda approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

craft like an artist 🎨 🖌️

@cpl121 cpl121 merged commit 9e73235 into develop-iota2.0 Feb 26, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/add-delegation-view branch February 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add Delegation view UI
3 participants
@cpl121 @marc2332 @evavirseda