Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a delegation popup logic #8082

Merged
merged 33 commits into from
Mar 1, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Feb 21, 2024

Closes #8072

The balance available is not accurate since it does not take into account the delegation outputs, in addition, the delegation output is not detected when syncing
I have created this issue to fix it when it is ready

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Feb 21, 2024 that may be closed by this pull request
cpl121 and others added 15 commits February 21, 2024 13:58
…thub.com:iotaledger/firefly into feat/add-delegation-view
…ation-view' of github.com:iotaledger/firefly into feat/add-create-delegation-popup
…ate-delegation-popup' of github.com:iotaledger/firefly into feat/create-delegation-popup-logic
…0' of github.com:iotaledger/firefly into feat/add-create-delegation-popup
…ate-delegation-popup' of github.com:iotaledger/firefly into feat/create-delegation-popup-logic
Base automatically changed from feat/add-create-delegation-popup to develop-iota2.0 February 26, 2024 16:57
…2.0' of github.com:iotaledger/firefly into feat/create-delegation-popup-logic
…2.0' of github.com:iotaledger/firefly into feat/create-delegation-popup-logic
…2.0' of github.com:iotaledger/firefly into feat/create-delegation-popup-logic
…2.0' of github.com:iotaledger/firefly into feat/create-delegation-popup-logic
@cpl121 cpl121 marked this pull request as ready for review February 28, 2024 18:15
@cpl121 cpl121 changed the title feat: create a delegation popup logic WIP feat: create a delegation popup logic Feb 28, 2024
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant delegate for some reason 🤔
image
Also, when I enter the password the amount I entered resets, it always go to the max no matter how much I selected

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd merged commit fd3ac60 into develop-iota2.0 Mar 1, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/create-delegation-popup-logic branch March 1, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Create a delegation popup Logic
2 participants