Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update base token send to include mana cost of the tx #8101

Merged

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Feb 27, 2024

Closes #7848

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 changed the title fix: getAddressFromSubject feat: update base token send to include mana cost of the tx Feb 27, 2024
@cpl121 cpl121 linked an issue Feb 27, 2024 that may be closed by this pull request
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 amazing, lets not merge it for now until the SDK adds the not unlocking of the inputs on prepare transaction 🌷

… 'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-base-token-send-to-include-mana-cost
@cpl121 cpl121 merged commit 95ba7e6 into develop-iota2.0 Mar 4, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/update-base-token-send-to-include-mana-cost branch March 4, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update base token send to include mana cost of the tx
2 participants