feat: claim rewards from delegation outputs #8136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lop-iota2.0' of github.com:iotaledger/firefly into feat/claim-rewards-from-delegation-outputs
…lop-iota2.0' of github.com:iotaledger/firefly into feat/claim-rewards-from-delegation-outputs
marc2332
requested changes
Mar 12, 2024
| onConfirm: async () => { | ||
| await checkActiveProfileAuth( | ||
| async () => { | ||
| // TODO: Update the delegationId when https://github.com/iotaledger/firefly/issues/8188 is merged |
There was a problem hiding this comment.
Although we don't have computeDelegationId we can use computeAccountId
marc2332
requested changes
Mar 12, 2024
| // TODO: add logic to claim reward | ||
| function handleClaimRewards(outputId: string, delegationId: string): void { | ||
| if (delegationId === EMPTY_HEX_ID) { | ||
| // TODO: Update with computeDelegationId when https://github.com/iotaledger/firefly/issues/8188 is merged |
There was a problem hiding this comment.
#8188 got closed, we can now use computeDelegationId
marc2332
requested changes
Mar 12, 2024
…lop-iota2.0' of github.com:iotaledger/firefly into feat/claim-rewards-from-delegation-outputs
Co-authored-by: Marc Espin <mespinsanz@gmail.com>
marc2332
approved these changes
Mar 12, 2024
…om:iotaledger/firefly into feat/claim-rewards-from-delegation-outputs
…feat/claim-rewards-from-delegation-outputs
…lop-iota2.0' of github.com:iotaledger/firefly into feat/claim-rewards-from-delegation-outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7990
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist