-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show BIC balance in account details #8151
feat: show BIC balance in account details #8151
Conversation
…p-iota2.0' of github.com:iotaledger/firefly into feat/show-bic-balance-in-account-details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it better to keep things this simple
packages/shared/lib/core/wallet/interfaces/extended-balance.interface.ts
Outdated
Show resolved
Hide resolved
...views/dashboard/wallet/views/implicit-account-creation-multistep/FundConfirmationView.svelte
Outdated
Show resolved
Hide resolved
…p-iota2.0' of github.com:iotaledger/firefly into feat/show-bic-balance-in-account-details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, just a little detail:pray:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add logic to get BIC if there are explicit accounts to buildWalletState.ts
Closes #8145
To try it for the first time, you must update
syncBalance
for the first time in one of the following wayssyncBalance(initialSelectedWalletId, true)
in the login in one of the final stepshandleNewOutputEvent
orhandleSpentOutputEvent
)Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist