Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show BIC balance in account details #8151

Merged

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Mar 6, 2024

Closes #8145

To try it for the first time, you must update syncBalance for the first time in one of the following ways

  • Adding syncBalance(initialSelectedWalletId, true) in the login in one of the final steps
  • Creating an account or making a transfer (launch handleNewOutputEvent or handleSpentOutputEvent)

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Mar 6, 2024 that may be closed by this pull request
@cpl121 cpl121 marked this pull request as ready for review March 6, 2024 21:11
marc2332 and others added 3 commits March 7, 2024 13:04
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it better to keep things this simple

…p-iota2.0' of github.com:iotaledger/firefly into feat/show-bic-balance-in-account-details
@cpl121 cpl121 requested a review from marc2332 March 11, 2024 16:36
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, just a little detail:pray:

packages/shared/locales/en.json Outdated Show resolved Hide resolved
@cpl121 cpl121 requested a review from evavirseda March 18, 2024 16:18
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 🚀

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add logic to get BIC if there are explicit accounts to buildWalletState.ts

@begonaalvarezd begonaalvarezd merged commit 1b5576d into develop-iota2.0 Mar 19, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/show-bic-balance-in-account-details branch March 19, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: show BIC balance in account details
4 participants