feat: improve delegation list header #8155
Conversation
…a2.0' of github.com:iotaledger/firefly into feat/improve-delegation-list-header
…a2.0' of github.com:iotaledger/firefly into feat/improve-delegation-list-header
…a2.0' of github.com:iotaledger/firefly into feat/improve-delegation-list-header
| $: delegationOutputs = | ||
| $selectedWallet?.walletUnspentOutputs?.filter((output) => output?.output?.type === OutputType.Delegation) || [] | ||
| $: delegationOutputs?.length > 0 && mappedDelegationData(delegationOutputs) |
There was a problem hiding this comment.
mappedDelegationData looks like its a variable, this should be renamed to a getter or a setter or something
| delegationOutputs?.map(async (output) => { | ||
| const delegationOutput = output.output as DelegationOutput | ||
| // Until the first epoch in which it was delegated ends, no rewards are obtained | ||
| const epochsDelegating = currentEpoch - delegationOutput.startEpoch |
There was a problem hiding this comment.
shouldnt it be currentEpoch - delegationOutput.startEpoch - 1
There was a problem hiding this comment.
I also thought like this, but when a delegation output is created, the startEpoch is currentEpoch + 1
In the tests I did, the currentEpoch was 3 and the startEpoch of the newly created delegation output was 4
| return { | ||
| [Header.Name]: `Delegation ${index + 1}`, | ||
| [Header.DelegationId]: delegationOutput.delegationId, | ||
| [Header.DelegatedFunds]: Number(delegationOutput.delegatedAmount), | ||
| [Header.Rewards]: await getOutputRewards(output.outputId), |
There was a problem hiding this comment.
getOutputRewards should not live in this component, i would move that logic out so its reusable somewhere else, these types of logics dont make sense in a svelte component
| return Number(rewards) | ||
| } | ||
|
|
||
| async function getCurrentEpoch(): Promise<void> { |
There was a problem hiding this comment.
this should be moved somewhere else outside of this component too
Closes #8148
Closes #8106
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist