Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check if the validator address belongs to the validator committee #8178

Merged

Conversation

cpl121
Copy link
Collaborator

@cpl121 cpl121 commented Mar 8, 2024

Closes #8172

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

…a2.0' of github.com:iotaledger/firefly into feat/improve-delegation-list-header
… 'feat/improve-delegation-list-header' of github.com:iotaledger/firefly into feat/check-validator-address-belongs-to-comittee
…a2.0' of github.com:iotaledger/firefly into feat/improve-delegation-list-header
… 'feat/improve-delegation-list-header' of github.com:iotaledger/firefly into feat/check-validator-address-belongs-to-comittee
@cpl121 cpl121 marked this pull request as ready for review March 11, 2024 13:41
@cpl121 cpl121 requested a review from marc2332 March 11, 2024 13:41
Base automatically changed from feat/improve-delegation-list-header to develop-iota2.0 March 12, 2024 16:40
cpl121 and others added 4 commits March 12, 2024 18:38
… 'develop-iota2.0' of github.com:iotaledger/firefly into feat/check-validator-address-belongs-to-comittee
… 'develop-iota2.0' of github.com:iotaledger/firefly into feat/check-validator-address-belongs-to-comittee
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting logAndNotifyError.ts:15 cannot deserialize AccountAddress: missing field accountId at line 1 column 54 not sure if whether I am using an old SDK or what

… 'develop-iota2.0' of github.com:iotaledger/firefly into feat/check-validator-address-belongs-to-comittee
@cpl121
Copy link
Collaborator Author

cpl121 commented Mar 19, 2024

I am getting logAndNotifyError.ts:15 cannot deserialize AccountAddress: missing field accountId at line 1 column 54 not sure if whether I am using an old SDK or what

I can see it well with the latest version of the sdk
Captura de pantalla de 2024-03-19 14-21-04

@cpl121 cpl121 requested a review from marc2332 March 19, 2024 13:22
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@begonaalvarezd begonaalvarezd dismissed marc2332’s stale review March 21, 2024 11:30

error is not present

@begonaalvarezd begonaalvarezd merged commit 58cbb06 into develop-iota2.0 Mar 21, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/check-validator-address-belongs-to-comittee branch March 21, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: check if the validator address belongs to the validator committee
4 participants