feat: Sync with SDK #8181
Merged
feat: Sync with SDK #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc2332
commented
Mar 8, 2024
packages/shared/lib/core/nfts/tests/buildNftFromNftOutput.test.ts
Outdated
Show resolved
Hide resolved
cpl121
requested changes
Mar 8, 2024
cpl121
approved these changes
Mar 8, 2024
This was
linked to
issues
Mar 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8180
Closes #8150
I took the opportunity to also simplify the address <-> bech32 logic as it is what has been mainly changed in the SDK
Let me know if anything else has changed