Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split the accounts from the list into two #8186

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Mar 11, 2024

Closes #8179

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Mar 11, 2024 that may be closed by this pull request
@cpl121 cpl121 marked this pull request as ready for review March 14, 2024 15:59
@cpl121 cpl121 requested a review from marc2332 March 14, 2024 15:59
@marc2332 marc2332 changed the title feat: split the accounts from the list into two WIP feat: split the accounts from the list into two Mar 15, 2024
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe try reducing the margin on top of "Pending accounts"
image

Also, it seems like I cannot scroll in the pending accounts section

image

@cpl121 cpl121 requested a review from marc2332 March 15, 2024 16:42
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also there are some warnings 🙏

@cpl121 cpl121 requested a review from evavirseda March 18, 2024 16:39
…and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/split-accounts-in-the-accounts-management-list
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job 🚀

cpl121 and others added 2 commits March 19, 2024 10:45
…and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/split-accounts-in-the-accounts-management-list
@begonaalvarezd begonaalvarezd merged commit 0fc02c9 into develop-iota2.0 Mar 19, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/split-accounts-in-the-accounts-management-list branch March 19, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: split the accounts from the list into two
4 participants