Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update startBackgroundSync & DEFAULT_SYNC_OPTIONS #8232

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #8107 and closes #8187

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda requested a review from cpl121 March 20, 2024 11:10
@evavirseda evavirseda changed the title feta: update startBackgroundSync & DEFAULT_SYNC_OPTIONS feta: update startBackgroundSync & DEFAULT_SYNC_OPTIONS Mar 20, 2024
@evavirseda evavirseda changed the title feta: update startBackgroundSync & DEFAULT_SYNC_OPTIONS feat: update startBackgroundSync & DEFAULT_SYNC_OPTIONS Mar 20, 2024
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!! 🚀

@cpl121 cpl121 requested a review from marc2332 March 21, 2024 08:50
@begonaalvarezd begonaalvarezd merged commit 2f614ea into develop-iota2.0 Mar 21, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/update-startBackgroundSync branch March 21, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants