Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly send metadata feature in Send Flow #8317

Merged

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented Apr 4, 2024

Closes #8307
Closes #8120

Do we really want to support multiple metadata keys? (Regarding #8120)

Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 🚀
Captura de pantalla de 2024-04-04 23-33-02

@cpl121
Copy link
Member

cpl121 commented Apr 4, 2024

Do we really want to support multiple metadata keys?

Yes, I think that makes sense. Other platforms can create multiple metadata entries and we should show it
@marc2332

@marc2332
Copy link
Collaborator Author

marc2332 commented Apr 5, 2024

Do we really want to support multiple metadata keys?

Yes, I think that makes sense. Other platforms can create multiple metadata entries and we should show it @marc2332

Alright, I have unlinked the task so it can be addressed in the future.

Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job 🙌

@cpl121 cpl121 merged commit 33ba4da into develop-iota2.0 Apr 5, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the fix/properly-pass-metadata-feature-send-flow branch April 5, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix send with metadata not working
3 participants