Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reorder send inputs and ensure address input doesn't clear amount #836

Merged
merged 4 commits into from Apr 10, 2021
Merged

fix: reorder send inputs and ensure address input doesn't clear amount #836

merged 4 commits into from Apr 10, 2021

Conversation

cvarley100
Copy link
Contributor

Description of change

  • Reorders amount below address input
  • Fixes a bug where typing in the address cleared the amount

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Tested on Mac

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

begonaalvarezd
begonaalvarezd approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #829

@begonaalvarezd begonaalvarezd merged commit a10990b into develop Apr 10, 2021
@begonaalvarezd begonaalvarezd deleted the fix/send-inputs branch April 10, 2021 16:31
@begonaalvarezd begonaalvarezd mentioned this pull request Apr 10, 2021
Closed
@cvarley100 cvarley100 mentioned this pull request Apr 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cvarley100 @begonaalvarezd