Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename testnet to shimmer testnet, add new iota testnet network & add iota testnet evm #8385

Merged
merged 16 commits into from
Apr 18, 2024
Merged

chore: rename testnet to shimmer testnet, add new iota testnet network & add iota testnet evm #8385

merged 16 commits into from
Apr 18, 2024

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

Close #8384

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

cpl121
cpl121 requested changes Apr 16, 2024
View reviewed changes
packages/shared/lib/core/network/constants/default-base-token.constant.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/constants/default-base-token.constant.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/constants/default-network-metadata.constant.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/network/enums/token-supply.enum.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/profile/actions/profiles/checkAndMigrateProfiles.ts Show resolved Hide resolved
packages/shared/lib/core/profile/actions/profiles/checkAndMigrateProfiles.ts Show resolved Hide resolved
packages/shared/lib/core/profile/actions/profiles/checkAndMigrateProfiles.ts Show resolved Hide resolved
packages/shared/lib/core/network/utils/getEnabledNetworkFromFeatureFlags.ts Outdated Show resolved Hide resolved
cpl121
cpl121 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal comment, the rest is all good to me 👌🏼

packages/shared/lib/core/network/enums/token-supply.enum.ts Show resolved Hide resolved
@begonaalvarezd begonaalvarezd marked this pull request as ready for review April 18, 2024 11:24
@begonaalvarezd begonaalvarezd merged commit cbb1019 into develop Apr 18, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the chore/testnets branch April 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Update testnets
2 participants
@begonaalvarezd @cpl121