Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Activity row dark more styling #985

Merged
merged 2 commits into from Apr 27, 2021
Merged

Conversation

obany
Copy link
Contributor

@obany obany commented Apr 21, 2021

Description of change

The styling for the activity rows in dark mode didn't use the account color.
In addition the dark mode transaction details used white on colored background for the account initials which was hard to read.

image

image

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Tested on windows in dark mode

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner April 21, 2021 15:08
@cvarley100 cvarley100 merged commit bc8384a into develop Apr 27, 2021
@cvarley100 cvarley100 deleted the fix/activity-row-dark-mode branch April 27, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants