Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't issue or schedule messages older than TSC #2264

Open
piotrm50 opened this issue Jun 8, 2022 · 0 comments
Open

Don't issue or schedule messages older than TSC #2264

piotrm50 opened this issue Jun 8, 2022 · 0 comments
Assignees

Comments

@piotrm50
Copy link
Contributor

piotrm50 commented Jun 8, 2022

Both rate-setter and scheduler introduce delay before message is gossiped from the original node. Sometimes the delay might be so big, that by the time the message arrives to the node's tip pool, it's already invalid because it doesn't satisfy the TSC condition.

Make sure to discard such messages in the scheduler and rate setter (if the delay is already large enough in rate setter).

This issue can only be resolved when TSC and new time concepts PR is merged to develop.

@piotrm50 piotrm50 self-assigned this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant