Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check default and no-default-features in CI #1042

Merged
merged 3 commits into from Sep 22, 2022
Merged

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented Sep 22, 2022

Description of change

Checks each crate in the workspace can compile with their default features and without any features enabled at all.

Each crate must be compiled individually since some enable features on others.

Type of change

  • Chore (a non-breaking change which fixes an issue)

How the change has been tested

Tested the commands locally in WSL.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added the No changelog Excludes PR from becoming part of any changelog label Sep 22, 2022
@cycraig cycraig self-assigned this Sep 22, 2022
@cycraig cycraig merged commit c4916a6 into dev Sep 22, 2022
@cycraig cycraig deleted the chore/ci-check-features branch September 22, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants