Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update identity 0.6 to Stronghold 2.0 #1174

Merged
merged 9 commits into from
Aug 3, 2023

Conversation

PhilippGackstatter
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter commented May 24, 2023

Description of change

Upgrade stronghold to 2.0.

  • Handle breaking changes in stronghold in a non-breaking manner. The API is not broken, however the behavior is which requires a manual migration of the old strongholds to the new snapshot format introduced in Stronghold 2.0.
  • Update Cargo.lock in stronghold-nodejs which is necessary for a successful build of those bindings.
  • Remove the outdated null ptr lint on support/v0.6, analogously to what was done in Remove outdated lint #1111.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

This PR was tested by running the account_create on the current support/v0.6. The resulting stronghold snapshot was then used as input for migrating the snapshot from v2 to v3 using the migrate_stronghold_snapshot_v2_to_v3 example (and using "identity.rs" as the salt) from iota-sdk (currently on iotaledger/iota-sdk#456).

Then the account_create_vc example was modified to load the existing DID and the v3 snapshot using the code from this PR and signing with the existing method whose key is in the stronghold. The example ran successfully.

It was also tested that an upate to an identity can be performed, signed by a key in the migrated stronghold, published and successfully resolved.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. labels May 24, 2023
@PhilippGackstatter PhilippGackstatter added this to the v0.6 Features milestone May 24, 2023
@PhilippGackstatter PhilippGackstatter added the Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog label May 24, 2023
@PhilippGackstatter PhilippGackstatter marked this pull request as ready for review May 27, 2023 16:24
Copy link
Collaborator

@eike-hass eike-hass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merged blocked until we have a Stronghold 2.0 final though.

@PhilippGackstatter PhilippGackstatter merged commit 9845be0 into support/v0.6 Aug 3, 2023
14 checks passed
@PhilippGackstatter PhilippGackstatter deleted the feat/stronghold2 branch August 3, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants