Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RevocationBitmap2022 encoding bug #1292

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Feb 5, 2024

Description of change

Fixes an encoding error in RevocationBitmap2022.

Links to any relevant issues

Fixes issue #1291.
Our implementation of RevocationBitmap2022 had a bug in the code that takes care of encoding the bitmap into a credential service URL. This bug caused a double base64 encoding for the binary list which this PR fixes.
All revocation bitmaps encoded as credential's services before this PR will still be properly decoded and any update on them will fix their encoding.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Added unit tests for both encoding and decoding functions.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@UMR1352 UMR1352 requested a review from a team as a code owner February 5, 2024 09:55
@UMR1352 UMR1352 added Bug Something isn't working. Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Feb 5, 2024
Copy link
Collaborator

@eike-hass eike-hass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see it simplified! Would be good to add some additional information in the PR description and title so it can serve as a reference when linked from the changelog.

@UMR1352 UMR1352 changed the title Double encoded revocation bitmap Fix RevocationBitmap2022 encoding bug Feb 6, 2024
Copy link
Contributor

@abdulmth abdulmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for working on it. We still have to clean up the wiki. So maybe we can keep the issue open for now.

@UMR1352 UMR1352 merged commit 22f042a into main Feb 6, 2024
16 of 17 checks passed
@UMR1352 UMR1352 deleted the bug/double-encoded-revocation-bitmap branch February 6, 2024 13:12
@eike-hass eike-hass added the Wasm Related to Wasm bindings. Becomes part of the Wasm changelog label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants