Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the Identity Agent #322
Implement the Identity Agent #322
Changes from 222 commits
6708385
fb90837
0fb255f
fea1cfd
85b2018
4d493b9
8ff162a
d50633c
94f743e
ac444fc
5de923e
d64fa17
841c8f1
15d0899
a103e82
b1c3f50
5286db7
6e9f22c
4a335fa
d04c478
0ea1a07
0444cce
5754455
d189efa
c5af33b
c734593
8d9983c
b8765b5
d1e6caf
ba78591
4be9d93
3a40b20
d47efc1
3c41ee6
56d8c8b
ef6afc1
8a7a56b
bf4188a
9e6dcdd
d5f8bdb
806a0e1
57cf41d
2c0891d
7a47dbd
a1ed930
313f955
307a7fb
ede1ef0
2ba7a26
ab47c83
1f6175d
7f69457
293e2ac
8aab6b2
910abbe
7b746bc
17e42dd
844b9b2
ed2869b
352c2fb
070a28b
a95c8cc
1951a83
93b773e
81c7917
1e253e9
4f037e5
807e9f4
0ef1360
bf0028e
f2d0921
454069e
8f71d2c
8f01558
40c44c2
a6d330c
7b4ec79
dd5e592
8e490d2
60ea0ca
8643565
a159ce0
c74e05f
6a0a341
e4d61d0
5ed9de9
6362dcb
7d9263a
16b1572
6e0a86e
432c110
4da9eef
fe46e5b
a5356f7
65ac5e7
c174ee1
7522962
81e21fa
6cfb359
9204942
f2c9782
b94c921
568f1b9
b69d5b9
5f74ac0
48e665e
f834748
d934149
85ef809
9993015
9663780
435a92b
cc47f5a
e8607b1
c1da194
2533e28
a426826
ddb9f45
220b545
c42741b
2bec251
8a03293
6b32a04
f6a2d0c
56f1327
1f7ab7b
aaffb8b
d17f06f
a2b5d12
f8e7201
0b1e3da
7fe43d8
a8a51d2
ca8b1da
b662ea2
a3527a4
c2a7e3f
477a945
efe8cd2
8c98360
998d2f8
5afe260
95e466d
74d409d
d507c4a
a519665
a43e6ce
76c45ca
9004e65
a760fee
6708434
a2faa55
616d0ef
2e2cd07
4abd401
97eae18
24213de
c41cf02
7c5a7ca
37470f7
844e42c
23872ed
8dc6a88
309e67a
9a53471
2fae7e3
4fe4e7a
2ee9901
4d6df63
2d4751c
6d2e030
0fb39bf
4e8247e
503a986
7d698d5
1ca45c9
17c6208
fe61a9f
f636bfe
0bfe13d
d810dbf
74eb6bd
8e15d95
e1bbd5b
bdd4902
6f36d4b
54e4985
461f599
9929b7c
f16da65
da52855
8ca19dc
d16b6d0
0acf6e5
f3dac5c
dd7fd28
b77f7a8
18f4343
8c19d69
fdfeaca
b5608e5
805ceaa
26ff921
3c6c664
b06a65b
4dd870f
1d23d3f
ca40ea9
93b0e34
88edc88
0b771f7
0a6460b
b347905
0b97d5e
14a18da
3adcb3d
ad7e1b5
ebd76ae
257927b
cb5d1e5
1aa8a9d
3966006
9cda00a
9ba9485
07c8d20
19f6ef6
7f70a0b
64402d4
e43844f
841f908
fe180ce
3a7235c
138d838
e2a3bdb
2bb3dff
e47dbb3
ce1fa9e
b03e559
7702e73
65f32ef
c5a15f9
c21e40a
1c7162e
f85f667
221a46f
01721c2
7cf621c
4d3387b
56d5423
4e799b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fairly expensive operation hence I am concerned the benchmark ends up primarily benchmarking account creation which is an operation implemented in another crate.
I do however agree with benching realistic use cases and it would be nice if we could find another such example, but where less time is spent inside the handler. Perhaps something like benchmarking sending a presentation request/offer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a second benchmark that purely tests DIDComm operations.