Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brittle agent test #936

Merged
merged 2 commits into from Jul 5, 2022
Merged

Fix brittle agent test #936

merged 2 commits into from Jul 5, 2022

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Fixes an agent test that appears to be brittle on some systems or platforms or situations - it's unclear what exactly the problem is.

The order of addresses and addresses themselves returned from Agent::addresses aren't the same across executions, so the occassional failures appear to come from times when the first address that is picked isn't dialable.
This is fixed by adding all addresses for an agent, which allows libp2p to attempt a dial for all of them.

Also fixes the crate description to match the README.

Links to any relevant issues

n/a

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

The test was run on the affected system and appears to work consistently now.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@PhilippGackstatter PhilippGackstatter added No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jul 5, 2022
Copy link
Contributor

@olivereanderson olivereanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shame we cannot find the exact cause of this now.

@PhilippGackstatter PhilippGackstatter merged commit 88f8a5a into dev Jul 5, 2022
@PhilippGackstatter PhilippGackstatter deleted the fix/spurious-agent-test branch July 5, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants