Fix wasm compilation, bump wasm-bindgen (#2221)

* Fix wasm compilation, bump wasm-bindgen * Update dependencies
iotaledger · Apr 16, 2024 · fba9feb · fba9feb
1 parent 8dd0d73
commit fba9feb
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 18 deletions.
diff --git a/.github/workflows/bindings-wasm-publish.yml b/.github/workflows/bindings-wasm-publish.yml
@@ -25,7 +25,7 @@ jobs:
       - name: Install wasm-bindgen-cli
         uses: jetli/wasm-bindgen-action@v0.2.0
         with:
-          version: "0.2.91"
+          version: "0.2.92"
 
       - name: Set up Node.js
         uses: actions/setup-node@v3

diff --git a/.github/workflows/bindings-wasm.yml b/.github/workflows/bindings-wasm.yml
@@ -65,7 +65,7 @@ jobs:
       - name: Install wasm-bindgen-cli
         uses: jetli/wasm-bindgen-action@v0.2.0
         with:
-          version: "0.2.91"
+          version: "0.2.92"
 
       - name: Set Up Node.js ${{ matrix.node }} and Yarn Cache
         uses: actions/setup-node@v3

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/bindings/wasm/Cargo.toml b/bindings/wasm/Cargo.toml
@@ -28,7 +28,7 @@ js-sys = { version = "0.3.68", default-features = false, features = [] }
 log = { version = "0.4.20", default-features = false }
 serde_json = { version = "1.0.113", default-features = false }
 tokio = { version = "1.36.0", default-features = false, features = ["sync"] }
-wasm-bindgen = { version = "0.2.91", default-features = false, features = [
+wasm-bindgen = { version = "0.2.92", default-features = false, features = [
     "spans",
     "std",
     "serde-serialize",

diff --git a/sdk/src/client/core.rs b/sdk/src/client/core.rs
@@ -62,12 +62,13 @@ pub struct ClientInner {
     pub(crate) request_pool: RequestPool,
 }
 
+#[cfg(not(target_family = "wasm"))]
 #[derive(Default)]
 pub(crate) struct SyncHandle(pub(crate) Option<tokio::task::JoinHandle<()>>);
 
+#[cfg(not(target_family = "wasm"))]
 impl Drop for SyncHandle {
     fn drop(&mut self) {
-        #[cfg(not(target_family = "wasm"))]
         if let Some(sync_handle) = self.0.take() {
             sync_handle.abort();
         }